fix(remote): grant the deploy role secretsmanager:PutSecretValue - #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key rotation deploys fail: the deploy role lacks the action 1.31.0's rotation path needs.
Summary
remote deploy --api-key-env(1.31.0) rotates an existing environment's key secret viasecretsmanager:PutSecretValue, but the deploy Lambda's role was only ever granted the create-path actions (CreateSecret,DescribeSecret) — so a rotation deploy dies with an IAM denial wrapped as HTTP 502.secretsmanager:PutSecretValueto the deploy role's grant, scoped to the same per-environmentcloud-vm-llm/*secret prefix, with the stack test asserting it.Implementation details
remote bootstrapre-run: an idempotent stack update that changes only the role's policy (no AMI bake, no reseed, no environment redeploy).